[PATCH] D44035: OpenBSD pthread interceptor subset

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/sanitizer_common/CMakeLists.txt:19
   sanitizer_mac.cc
+  sanitizer_openbsd.cc
   sanitizer_persistent_allocator.cc
----------------
vitalybuka wrote:
> CMakeLists.txt change should be in the patch which adds this files
Ok makes sense.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:4430
+COMMON_INTERCEPTOR_PTHREAD_ATTR_GET                             \
+INTERCEPTOR_PTHREAD_ATTR_GET(schedparam, struct_sched_param_sz) \
+INTERCEPTOR_PTHREAD_ATTR_GET(schedpolicy, sizeof(int))          
----------------
vitalybuka wrote:
> if we SANITIZER_INTERCEPT_PTHREAD_ATTR_GET is not enough
> we should add SANITIZER_INTERCEPT_PTHREAD_ATTR_GET_SCHED
> 
> are *sched* calls missing on openbsd? 
Yes.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44035