[PATCH] D44035: OpenBSD UBsan support / common part 2

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

Could you please improve title?
Ubsan should not install pthread interceptors.



================
Comment at: lib/sanitizer_common/CMakeLists.txt:19
   sanitizer_mac.cc
+  sanitizer_openbsd.cc
   sanitizer_persistent_allocator.cc
----------------
CMakeLists.txt change should be in the patch which adds this files


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:4430
+COMMON_INTERCEPTOR_PTHREAD_ATTR_GET                             \
+INTERCEPTOR_PTHREAD_ATTR_GET(schedparam, struct_sched_param_sz) \
+INTERCEPTOR_PTHREAD_ATTR_GET(schedpolicy, sizeof(int))          
----------------
if we SANITIZER_INTERCEPT_PTHREAD_ATTR_GET is not enough
we should add SANITIZER_INTERCEPT_PTHREAD_ATTR_GET_SCHED

are *sched* calls missing on openbsd? 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44035