[PATCH] D43799: Error instead of allocating a header bellow address 0

[George Rimar via llvm-commits]

I also can suggest the patch attached as a followup refactoring.


Best regards,
George | Developer | Access Softek, Inc

________________________________________
От: George Rimar via Phabricator <reviews at reviews.llvm.org>
Отправлено: 1 марта 2018 г. 16:21
Кому: rafael at espindo.la; ruiu at google.com; George Rimar; jh7370 at my.bristol.ac.uk
Копия: emaste at freebsd.org; arichardson.kde at gmail.com; llvm-commits at lists.llvm.org
Тема: [PATCH] D43799: Error instead of allocating  a header bellow address 0

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

This LGTM with few nits.



================
Comment at: ELF/LinkerScript.cpp:909

+  bool Allocateheaders =
+      llvm::any_of(PhdrsCommands, [](const PhdrsCommand &Cmd) {
----------------
`Allocateheaders` -> `AllocateHeaders` ?
Or may be `HasExplicitHeaders` would be better.


================
Comment at: ELF/LinkerScript.cpp:923
+  if (Allocateheaders)
+    error("Could not allocate headers");
+
----------------
Could -> could.


https://reviews.llvm.org/D43799



-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.patch
Type: application/octet-stream
Size: 41108 bytes
Desc: patch.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180301/db09ea70/attachment-0001.obj>