[PATCH] D43799: Error instead of allocating a header bellow address 0
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 1 05:21:15 PST 2018
grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.
This LGTM with few nits.
================
Comment at: ELF/LinkerScript.cpp:909
+ bool Allocateheaders =
+ llvm::any_of(PhdrsCommands, [](const PhdrsCommand &Cmd) {
----------------
`Allocateheaders` -> `AllocateHeaders` ?
Or may be `HasExplicitHeaders` would be better.
================
Comment at: ELF/LinkerScript.cpp:923
+ if (Allocateheaders)
+ error("Could not allocate headers");
+
----------------
Could -> could.
https://reviews.llvm.org/D43799
More information about the llvm-commits
mailing list