[PATCH] D43620: [Pipeliner] Fixed node order issue related to zero latency edges

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

Thanks for the detailed explanation. That make sense, and I agree that the ZLD/ZLH is a more general/better solution.



================
Comment at: lib/CodeGen/MachinePipeliner.cpp:1615
                                   getDistance(pred, SU, *IP) * MII));
+      if (getLatency(SU, *IP) == 0)
+        zeroLatencyDepth =
----------------
I think the zeroLatencyDepth (and Height) calculation needs to be done prior to the ignoreDependence() check. Otherwise, Anti dependence edges won't be considered in the ZLD/ZLH calculation.


Repository:
  rL LLVM

https://reviews.llvm.org/D43620