[PATCH] D43620: [Pipeliner] Fixed node order issue related to zero latency edges

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added inline comments.


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:2085
+                     getZeroLatencyHeight(I) > getZeroLatencyHeight(maxHeight))
               maxHeight = I;
+            else if (getHeight(I) == getHeight(maxHeight) &&
----------------
sorry, I add that comment to the wrong line.  See below.


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:2130
             else if (getDepth(I) == getDepth(maxDepth) &&
-                     getMOV(I) < getMOV(maxDepth) &&
-                     !hasDataDependence(I, maxDepth))
+                     getZeroLatencyDepth(I) > getZeroLatencyHeight(maxDepth))
               maxDepth = I;
----------------
this is the place where I meant to add the change - 
getZeroLatencyHeight(maxDepth) with getZeroLatencyDepth(maxDepth)


Repository:
  rL LLVM

https://reviews.llvm.org/D43620