[PATCH] D43828: Put undefined symbols from shared libraries in the symbol table

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 12:39:32 PST 2018


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On February 27, 2018 12:10 PM, Rui Ueyama via Phabricator <reviews at reviews.llvm.org> wrote:

> ​​
> 
> ruiu accepted this revision.
> 
> ruiu added a comment.
> 
> This revision is now accepted and ready to land.
> 
> LGTM
> 
> This change seems pretty good. I didn't notice that just adding undefined symbols simplifies things like this. Can we now implement --no-allow-shlib-undefined easily as well?

More or less. We would still need to follow DT_NEEDED and actually report errors for undefined symbols from shared libraries.

Cheers,
Rafael



More information about the llvm-commits mailing list