[PATCH] D43828: Put undefined symbols from shared libraries in the symbol table

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

This change seems pretty good. I didn't notice that just adding undefined symbols simplifies things like this. Can we now implement --no-allow-shlib-undefined easily as well?



================
Comment at: ELF/SymbolTable.cpp:297
       insert(Name, Type, Visibility, CanOmitFromDynSym, File);
+  if (File && File->kind() == InputFile::SharedKind)
+    S->ExportDynamic = true;
----------------
My preference is to do this in InputFiles.cpp instead of in this file.


https://reviews.llvm.org/D43828