[PATCH] D39976: [AArch64] Query the target when folding loads and stores

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 14:41:44 PST 2018


evandro added a comment.

In https://reviews.llvm.org/D39976#1017321, @gberry wrote:

> Would it not be simpler to just add a subtarget bool that controls whether the problematic opcodes are emitted and set it for your subtargets (similar to the way STRQroIsSlow is handled)?  That way you could avoid generating them not just in this pass, but in ISel and frame lowering?


Methinks that the gist is to move away from features and to rely more on the cost model.  In the case of this patch, it also removes the feature `FeatureSlowPaired128` in https://reviews.llvm.org/D40107.


https://reviews.llvm.org/D39976





More information about the llvm-commits mailing list