[PATCH] D43319: [test-suite] Adding LCALS (Livermore Compiler Analysis Loop Suite) loop kernels to test suite.

[Brian Homerding via Phabricator via llvm-commits]

homerdin added a comment.

Ya, just having the `lit.local.cfg` in `/Microbenchmark` will work.  See inline.



================
Comment at: MicroBenchmarks/LCALS/SubsetCRawLoops/lit.local.cfg:1-7
+test_modules = config.test_modules
+if 'run' in test_modules:
+    # Insert microbenchmark module behind 'run'
+    test_modules.insert(test_modules.index('run')+1, 'microbenchmark')
+    # Timeit results are not useful for microbenchmarks
+    if 'timeit' in test_modules:
+        test_modules.remove('timeit')
----------------
MatzeB wrote:
> It's enough to have this at the toplevel `/Microbenchmark` directory I think, and you shouldn't need to repeat it for each subdirectory, is it not?
Tested it and you're right, everything works with it in the `/Microbenchmark` directory so long as the subdirectory ones are removed.  

`microbenchmark.py` raises an exception if there are both.  So I added the `lit.local.cfg` in `/Microbenchmark` in  https://reviews.llvm.org/D43316 so nothing breaks in the XRay tests.  Would be better to commit that change first anyways, cause without it these tests produce 1 big number.
```
    # We need stdout outself to get the benchmark csv data.
    if cmd.stdout is not None:
        raise Exception("Rerouting stdout not allowed for microbenchmarks")
```


https://reviews.llvm.org/D43319