[PATCH] D43319: [test-suite] Adding LCALS (Livermore Compiler Analysis Loop Suite) loop kernels to test suite.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

- You should double check whether you really need to repeat the lit.local.cfg changes in each directory.
- I haven't actually tried compiling/running the benchmark but the changes LGTM.



================
Comment at: MicroBenchmarks/LCALS/SubsetCRawLoops/lit.local.cfg:1-7
+test_modules = config.test_modules
+if 'run' in test_modules:
+    # Insert microbenchmark module behind 'run'
+    test_modules.insert(test_modules.index('run')+1, 'microbenchmark')
+    # Timeit results are not useful for microbenchmarks
+    if 'timeit' in test_modules:
+        test_modules.remove('timeit')
----------------
It's enough to have this at the toplevel `/Microbenchmark` directory I think, and you shouldn't need to repeat it for each subdirectory, is it not?


https://reviews.llvm.org/D43319