[PATCH] D43643: [RFC] Sceptre a Spectre variant 1 detector

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 14:56:55 PST 2018


probinson added a comment.

In https://reviews.llvm.org/D43643#1016430, @efriedma wrote:

> I'm a little wary of giving people a false sense of security, since this checker only looks for a very narrow set of patterns.  (See discussion on https://reviews.llvm.org/D41761 .)


I understand the "leave no door unlocked" argument, although I also think the argument fails to consider that some doors are *way* harder to reach than others and these practical barriers are effectively locks of their own.  Nevertheless it's best to find as many as we can.

In his llvm-dev post, Rob says the checker can detect 9 of the 15 examples published by Paul Kocher (https://www.paulkocher.com/doc/MicrosoftCompilerSpectreMitigation.html).  Do you have additional patterns beyond that set, that you think we should look for?  Do you have suggestions for how to detect the patterns we don't find now?  This *is* a WIP.


Repository:
  rL LLVM

https://reviews.llvm.org/D43643





More information about the llvm-commits mailing list