[PATCH] D43643: [RFC] Sceptre a Spectre variant 1 detector

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Is the pass intentionally named "Sceptre"?  That's amusing, but kind of confusing.

I'm a little wary of giving people a false sense of security, since this checker only looks for a very narrow set of patterns.  (See discussion on https://reviews.llvm.org/D41761 .)



================
Comment at: lib/Analysis/Sceptre.cpp:157
+          unsigned NumValues = PN->getNumIncomingValues();
+          bool FollowPHI = NumValues > 0;
+
----------------
PHI nodes always have at least one incoming value.


Repository:
  rL LLVM

https://reviews.llvm.org/D43643