[PATCH] D43603: [utils] fixing update_mir_test_checks.py's greediness for `registers:` field

[Justin Bogner via Phabricator via llvm-commits]

bogner added a comment.

I like the idea of adding tests for update_mir_test_checks itself, but I think we should stick to focused tests rather than just adding one that tries to test everything. I also think this isn't a great place for it, maybe we could add a test/tools/update_checks folder for tests for all of the update_*_tests scripts? We might need to fake out llc to get away with something like that though...



================
Comment at: test/CodeGen/AArch64/test-update_mir_test_checks.py-itself.mir:11-14
+# STDERR-NOT:  WARNING
+# STDERR:      WARNING: [[TMP_FILE_NAME:/.*\.tmp]]: Skipping non-llc RUN line:
+# STDERR-SAME:     sed -e {{.*}} RUN-NESTED{{.*}}SOURCE{{.*}}STDERR{{.*}}SOURCE
+# STDERR-NOT:  WARNING
----------------
Is it necessary to check the stderr in this test?


Repository:
  rL LLVM

https://reviews.llvm.org/D43603