[PATCH] D43603: [utils] fixing update_mir_test_checks.py's greediness for `registers:` field

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin added a comment.

@bogner

I've also double checked that the test actually fails. On the original tool it fails with

  -- Testing: 1 tests, 1 threads --
  FAIL: LLVM :: CodeGen/AArch64/actual_test.mir (1 of 1)
  ******************** TEST 'LLVM :: CodeGen/AArch64/actual_test.mir' FAILED ********************
  Script:
  --
  sed -e 's/^# RUN-NESTED:/# RUN:/' /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir | sed -e 's/^# SOURCE.*$//' > /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp    && /Volumes/Data/llvm/test/CodeGen/AArch64/../../../utils/update_mir_test_checks.py --add-vreg-checks      /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp 2>&1 | /Volumes/Data/llvm/build/obj/bin/FileCheck /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir --check-prefix=STDERR    && cat /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp | /Volumes/Data/llvm/build/obj/bin/FileCheck /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir --check-prefix=SOURCE
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  <stdin>:2:1: error: STDERR-NOT: string occurred!
  WARNING: /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp: Error processing file
  ^
  /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir:14:15: note: STDERR-NOT: pattern specified here
  # STDERR-NOT: WARNING
                ^
  
  --
  
  ********************
  Testing Time: 0.21s
  ********************
  Failing Tests (1):
      LLVM :: CodeGen/AArch64/actual_test.mir
  
    Unexpected Failures: 1

If the issue with `registers:` field "fixed" by making its regexp non just optional, but non-greedy-optional (`??`) it will still fail:

  -- Testing: 1 tests, 1 threads --
  FAIL: LLVM :: CodeGen/AArch64/actual_test.mir (1 of 1)
  ******************** TEST 'LLVM :: CodeGen/AArch64/actual_test.mir' FAILED ********************
  Script:
  --
  sed -e 's/^# RUN-NESTED:/# RUN:/' /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir | sed -e 's/^# SOURCE.*$//' > /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp    && /Volumes/Data/llvm/test/CodeGen/AArch64/../../../utils/update_mir_test_checks.py --add-vreg-checks      /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp 2>&1 | /Volumes/Data/llvm/build/obj/bin/FileCheck /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir --check-prefix=STDERR    && cat /Volumes/Data/llvm/build/obj/test/CodeGen/AArch64/Output/actual_test.mir.tmp | /Volumes/Data/llvm/build/obj/bin/FileCheck /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir --check-prefix=SOURCE
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /Volumes/Data/llvm/test/CodeGen/AArch64/actual_test.mir:65:16: error: expected string not found in input
  # SOURCE-NEXT: ; CHECK: registers:
                 ^
  <stdin>:126:2: note: scanning from here
   ; CHECK: liveins: $w0, $w1
   ^
  
  --
  
  ********************
  Testing Time: 0.21s
  ********************
  Failing Tests (1):
      LLVM :: CodeGen/AArch64/actual_test.mir
  
    Unexpected Failures: 1


Repository:
  rL LLVM

https://reviews.llvm.org/D43603