[PATCH] D43152: [DWARFv5] Turn an assert into a diagnostic.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 18:16:54 PST 2018


probinson added a comment.

In https://reviews.llvm.org/D43152#1013279, @dblaikie wrote:

> Given the abundance of callers that know the call won't fail, perhaps it'd be appropriate to keep the original function name without Expected, then have a version of the function ('tryBlah') that returns Expected (& implement blah in terms of cantFail(tryBlah))


That would certainly be less churn, and I'm happy to go that way.


https://reviews.llvm.org/D43152





More information about the llvm-commits mailing list