[PATCH] D43152: [DWARFv5] Turn an assert into a diagnostic.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 08:46:10 PST 2018


dblaikie accepted this revision.
dblaikie added a comment.

Given the abundance of callers that know the call won't fail, perhaps it'd be appropriate to keep the original function name without Expected, then have a version of the function ('tryBlah') that returns Expected (& implement blah in terms of cantFail(tryBlah))


https://reviews.llvm.org/D43152





More information about the llvm-commits mailing list