[PATCH] D42479: DAGCombiner: Combine SDIV with non-splat vector pow2 divisor

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 17 16:31:56 PST 2018


RKSimon added a comment.

I still think it'd be better if you treated splat vectors as a vector instead of a scalar - your change to matchUnaryPredicate means that we're accepting UNDEF elements where we weren't before, which for DIV/REM opcodes is supposed to be a big no-no.

Also, please can you clean up the variable names to follow coding style (CamelCase capitalization etc.)?


Repository:
  rL LLVM

https://reviews.llvm.org/D42479





More information about the llvm-commits mailing list