[PATCH] D43406: Merge two small functions and add comments.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 16 12:57:17 PST 2018
ruiu added inline comments.
================
Comment at: lld/wasm/InputChunks.cpp:79
-static void applyRelocations(uint8_t *Buf, ArrayRef<OutputRelocation> Relocs) {
- if (!Relocs.size())
+// Copy this input chunk to an mmap'ed output file.
+void InputChunk::writeTo(uint8_t *Buf) const {
----------------
sbc100 wrote:
> How do you feel about documentation here vs declaration in the .h file?
Why not both? :)
https://reviews.llvm.org/D43406
More information about the llvm-commits
mailing list