[PATCH] D43406: Merge two small functions and add comments.

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/InputChunks.cpp:77
 
-static void applyRelocations(uint8_t *Buf, ArrayRef<OutputRelocation> Relocs) {
-  if (!Relocs.size())
----------------
I think this static function was probably a legacy of time where it have many calls sites.. Thanks for cleaning this up.


================
Comment at: lld/wasm/InputChunks.cpp:79
 
-static void applyRelocations(uint8_t *Buf, ArrayRef<OutputRelocation> Relocs) {
-  if (!Relocs.size())
+// Copy this input chunk to an mmap'ed output file.
+void InputChunk::writeTo(uint8_t *Buf) const {
----------------
How do you feel about documentation here vs declaration in the .h file?   


https://reviews.llvm.org/D43406