[PATCH] D43403: Refactor wasm/WriterUtil.{cpp,h}.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 12:39:10 PST 2018


ruiu added a comment.

> I sometimes find the format string more readable than lots of small strings fragments +'d together. But I don't feel strongly enough about to to break local convention.

Not everybody memorizes this Python-style format string, and lld doesn't have a lot of code that needs formatting strings (so even if there's something better, investing in it isn't worth the cost), so we generally avoid using that in lld.


https://reviews.llvm.org/D43403





More information about the llvm-commits mailing list