[llvm] r325361 - [ThinLTO] Fix data race in test

[Evgeny Leviant via llvm-commits]

?Yeah it was a mistake. I've fixed it.

________________________________
От: Teresa Johnson <tejohnson at google.com>
Отправлено: 16 февраля 2018 г. 20:10
Кому: Evgeny Leviant
Копия: llvm-commits
Тема: Re: [llvm] r325361 - [ThinLTO] Fix data race in test



On Fri, Feb 16, 2018 at 8:56 AM, Eugene Leviant via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
Author: evgeny777
Date: Fri Feb 16 08:56:33 2018
New Revision: 325361

URL: http://llvm.org/viewvc/llvm-project?rev=325361&view=rev
Log:
[ThinLTO] Fix data race in test

Modified:
    llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll

Modified: llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll?rev=325361&r1=325360&r2=325361&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll (original)
+++ llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll Fri Feb 16 08:56:33 2018
@@ -6,7 +6,7 @@

 ; Test to make sure importing and dead stripping works in the
 ; case where the target is a local function that also indirectly calls itself.
-; RUN: llvm-lto2 run -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS
+; RUN: llvm-lto2 run -thread-model=single -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS

Are you sure -thread-model is the right option here? I thought that affects code generation. Or do you want the LTO backends to be running in single-threaded mode? In that case, use -thinlto-threads=1

Teresa

 ; Make sure we import the promted indirectly called target
 ; IMPORTS: Import _ZL3foov.llvm.0



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



--
Teresa Johnson |         Software Engineer |     tejohnson at google.com<mailto:tejohnson at google.com> |     408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180216/afe313ad/attachment-0001.html>