<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Yeah it was a mistake. I've fixed it.<br>
</p>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> Teresa Johnson <tejohnson@google.com><br>
<b>Отправлено:</b> 16 февраля 2018 г. 20:10<br>
<b>Кому:</b> Evgeny Leviant<br>
<b>Копия:</b> llvm-commits<br>
<b>Тема:</b> Re: [llvm] r325361 - [ThinLTO] Fix data race in test</font>
<div> </div>
</div>
<div>
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Feb 16, 2018 at 8:56 AM, Eugene Leviant via llvm-commits
<span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
Author: evgeny777<br>
Date: Fri Feb 16 08:56:33 2018<br>
New Revision: 325361<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=325361&view=rev" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=325361&view=rev</a><br>
Log:<br>
[ThinLTO] Fix data race in test<br>
<br>
Modified:<br>
llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll<br>
<br>
Modified: llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll?rev=325361&r1=325360&r2=325361&view=diff" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/PGOProfile/thinlto_<wbr>samplepgo_icp3.ll?rev=325361&<wbr>r1=325360&r2=325361&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll (original)<br>
+++ llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll Fri Feb 16 08:56:33 2018<br>
@@ -6,7 +6,7 @@<br>
<br>
; Test to make sure importing and dead stripping works in the<br>
; case where the target is a local function that also indirectly calls itself.<br>
-; RUN: llvm-lto2 run -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS<br>
+; RUN: llvm-lto2 run -thread-model=single -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS<br>
</blockquote>
<div><br>
</div>
<div>Are you sure -thread-model is the right option here? I thought that affects code generation. Or do you want the LTO backends to be running in single-threaded mode? In that case, use -thinlto-threads=1</div>
<div><br>
</div>
<div>Teresa</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
; Make sure we import the promted indirectly called target<br>
; IMPORTS: Import _ZL3foov.llvm.0<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature"><span style="font-family:Times; font-size:medium">
<table cellspacing="0" cellpadding="0">
<tbody>
<tr style="color:rgb(85,85,85); font-family:sans-serif; font-size:small">
<td nowrap="" style="border-top:2px solid rgb(213,15,37)">Teresa Johnson |</td>
<td nowrap="" style="border-top:2px solid rgb(51,105,232)"> Software Engineer |</td>
<td nowrap="" style="border-top:2px solid rgb(0,153,57)"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td>
<td nowrap="" style="border-top:2px solid rgb(238,178,17)"> 408-460-2413</td>
</tr>
</tbody>
</table>
</span></div>
</div>
</div>
</div>
</div>
</body>
</html>