[PATCH] D43275: [AMDGPU]Increased vector length for global/constant loads.

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:262
+      AddrSpace == AS.CONSTANT_ADDRESS_32BIT) {
+    if (ST->getGeneration() <= AMDGPUSubtarget::NORTHERN_ISLANDS)
+      return 128;
----------------
Does amdgpu only support gfx6 (si) and above? I thought northern islands was supported by the r600 backend.


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h:121
   unsigned getMinVectorRegisterBitWidth() const;
+  unsigned getLoadVectorFactor(unsigned VF, unsigned LoadSize,
+                               unsigned ChainSizeInBytes,
----------------
I did not see where in this patch these new functions are being used. 


https://reviews.llvm.org/D43275