[PATCH] D43173: [CallSiteSplitting] Preserve DominatorTreeAnalysis.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:410
   auto &TLI = AM.getResult<TargetLibraryAnalysis>(F);
+  auto &DT = AM.getResult<DominatorTreeAnalysis>(F);
 
----------------
junbuml wrote:
> fhahn wrote:
> > junbuml wrote:
> > > Considering that this pass doesn't use DT, do we need to get DT to preserve DT ?
> > We need the current dominator tree, so we can update it. Not sure if there is a better way to get it though.
> I just wanted to ask if constructing DT in advance is just okay because this pass doesn't even use DT. Isn't it okay to construct DT when DT  is really required in a later pass?
I'll check. AFAIK CallSiteSplitting is run after a bunch of passes that require the DT to be constructed already and by saying we do not preserve the DT we force it to be re-computed.


Repository:
  rL LLVM

https://reviews.llvm.org/D43173