[PATCH] D43173: [CallSiteSplitting] Preserve DominatorTreeAnalysis.
Jun Bum Lim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 12 09:16:32 PST 2018
junbuml added inline comments.
================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:410
auto &TLI = AM.getResult<TargetLibraryAnalysis>(F);
+ auto &DT = AM.getResult<DominatorTreeAnalysis>(F);
----------------
fhahn wrote:
> junbuml wrote:
> > Considering that this pass doesn't use DT, do we need to get DT to preserve DT ?
> We need the current dominator tree, so we can update it. Not sure if there is a better way to get it though.
I just wanted to ask if constructing DT in advance is just okay because this pass doesn't even use DT. Isn't it okay to construct DT when DT is really required in a later pass?
Repository:
rL LLVM
https://reviews.llvm.org/D43173
More information about the llvm-commits
mailing list