[PATCH] D43107: Support for the mno-stack-arg-probe flag

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: docs/LangRef.rst:1564
     of the callee.
+``"no-stack-arg-probe"``
+    This attribute disables ABI-required stack probes, if any.
----------------
Is the "arg" part of the name significant? It seems to me this applies to stack probing in general, and that's not just for arguments?


================
Comment at: lib/Target/X86/X86WinAllocaExpander.cpp:243
     break;
   case Probe:
+    if (!NoStackArgProbe) {
----------------
It seems odd that we end up in this case when we're not actually going to probe. Could the code be changed so that we end up in the Sub case instead, since that seems to do what we want here?


Repository:
  rL LLVM

https://reviews.llvm.org/D43107