[PATCH] D43112: [WebAssembly] Use Symbol class heirarchy. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 11:31:30 PST 2018


sbc100 added a comment.

This change has some pretty serious merge conflict with the symbol change change that is in the pipeline so I won't land it without clear plan (Currently looking the resolving the merge myself, but might wait until the larger change lands).



================
Comment at: wasm/InputFiles.cpp:56
+    return DG->getVirtualAddress();
+  else
+    return 0;
----------------
dberris wrote:
> Do you need the else here?
I don't need it no, I know I know its not the lld style.. its just read better for me.   I'll remove though.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43112





More information about the llvm-commits mailing list