[PATCH] D43112: [WIP] [WebAssembly] Use Symbol class heirarchy. NFC.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 21:22:52 PST 2018


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM -- nothing obviously weird from my skim.



================
Comment at: wasm/InputFiles.cpp:56
+    return DG->getVirtualAddress();
+  else
+    return 0;
----------------
Do you need the else here?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43112





More information about the llvm-commits mailing list