[llvm] r323297 - Don't assume a null GV is local for ELF and MachO.

[Brooks Moses via llvm-commits]

On Fri, Feb 9, 2018 at 6:54 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Brooks Moses <bmoses at google.com> writes:
> > Thanks for the quickly-implemented fix!  Honestly, I'm not sure how to
> > fully test that this boots, but one of our grub developers has offered to
> > test things for me if needed, so I'll give this a quick try tomorrow
> > morning to make sure it builds in our build system, and then hand it off
> to
> > him for testing.  Hopefully we can let you know tomorrow afternoon if
> this
> > works and get you unblocked on re-committing the patch.
> >
> > If this is indeed the extent of the change required for grub, I agree
> with
> > your analysis that this shouldn't be a blocker.
>
> Any news? I would really like to recommit the patch.
>
> It seems unreasonable to hold back a llvm patch because another software
> has an incomplete linker implementation, specially when a patch is
> available.
>

Sorry for the delay -- my colleague reports that he's testing this now.  (I
think he was out yesterday.)

Do you have a reference for the part of the ELF ABI that describes why the
PLT32 references should be treated as PC32 references here?

Thanks,
- Brooks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180209/23e7f8f7/attachment.html>