[PATCH] D43102: Refactor how we decide which sections to sort

[Rafael Avila de Espindola via llvm-commits]

Michael Spencer via Phabricator <reviews at reviews.llvm.org> writes:

> Bigcheese accepted this revision.
> Bigcheese added a comment.
>
> Seems fine and removes the duplication of names. My only concern is mixing `--symbol-ordering-file` with call graph sort in `buildSectionOrder`. Currently in the patch call graph sorting is applied then the order file. With this the two would need to be mixed into a single `DenseMap`, or the loop would need to be duplicated (which is what the patch currently does).

I think the correct thing is to not sort twice:

* If both command lines are given, produce an error.
* Once we have the callgraph in the .o file, a command line takes
  precedence.

Cheers,
Rafael