[PATCH] D43102: Refactor how we decide which sections to sort

Michael Spencer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 17:47:32 PST 2018


Bigcheese accepted this revision.
Bigcheese added a comment.

Seems fine and removes the duplication of names. My only concern is mixing `--symbol-ordering-file` with call graph sort in `buildSectionOrder`. Currently in the patch call graph sorting is applied then the order file. With this the two would need to be mixed into a single `DenseMap`, or the loop would need to be duplicated (which is what the patch currently does).


https://reviews.llvm.org/D43102





More information about the llvm-commits mailing list