[PATCH] D43071: [ELF] - Support DSECT, COPY, INFO, OVERLAY output sections attributes.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 9 07:26:49 PST 2018
George Rimar <grimar at accesssoftek.com> writes:
>>> + if (consume("DSECT") || consume("COPY") || consume("INFO") ||
>>> + consume("OVERLAY")) {
>>> + expect(")");
>>> + Cmd->Dsect = true;
>>
>>Please use a more informative name (DontAlloc?) or at least add a
>>comment to the definition.
>>
>
> I used Dsect because we usually call members in according
> to documented name. And other names sound bit ambiguous probably.
But DSECT seems to be the one that is not used in practice.
> Though if we can use "DontAlloc" or "NonAlloc" I would be happy.
Both work for me. As you point out, copy, info and overlay are a bit too
generic for what this does.
Cheers,
Rafael
More information about the llvm-commits
mailing list