[PATCH] D43071: [ELF] - Support DSECT, COPY, INFO, OVERLAY output sections attributes.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 16:26:04 PST 2018


ruiu added a comment.

Why do you want them? Do you actually want to build "TianoCore UEFI" firmware with lld?



================
Comment at: ELF/ScriptParser.cpp:621
+// Reads an expression and/or the special directive for an output section
+// definition. Directive can be one of following: "(NOLOAD)", "(DSECT)",
+// "(COPY)", "(INFO)", "(OVERLAY)".
----------------
can be -> is


================
Comment at: ELF/ScriptParser.cpp:622
+// definition. Directive can be one of following: "(NOLOAD)", "(DSECT)",
+// "(COPY)", "(INFO)", "(OVERLAY)".
 //
----------------
 or "(OVERLAY)"

("A, B, C" isn't grammatically correct.)


https://reviews.llvm.org/D43071





More information about the llvm-commits mailing list