[PATCH] D42952: [ELF] - Make printHelp() print all targets supported.

[Rui Ueyama via llvm-commits]

On Tue, Feb 6, 2018 at 3:11 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
> > ruiu added a comment.
> >
> > I don't think I like this patch because it makes things more complicated
> than it can be. "Supported targets" are just informative for compatibility
> with GNU linkers, and it doesn't change often. I'm more comfortable with
> the current code than this one.
>
> Can we trim the output then?
>
> Currently we have
>
> -  outs() << Argv0 << ": supported targets: "
> -         << "elf32-i386 elf32-iamcu elf32-littlearm elf32-ntradbigmips "
> -         << "elf32-ntradlittlemips elf32-powerpc elf32-tradbigmips "
> -         << "elf32-tradlittlemips elf32-x86-64 "
> -         << "elf64-amdgpu elf64-littleaarch64 elf64-powerpc
> elf64-tradbigmips "
> -         << "elf64-tradlittlemips elf64-x86-64\n";
>
> Could we print something like "elf32-* elf64-*"?
>

It was added to appease libtool, and I believe libtool expects /supported
targets:.* elf/. So "supported targets: elf" should be enough.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180206/43bf341c/attachment.html>