[PATCH] D42952: [ELF] - Make printHelp() print all targets supported.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 15:11:55 PST 2018


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> I don't think I like this patch because it makes things more complicated than it can be. "Supported targets" are just informative for compatibility with GNU linkers, and it doesn't change often. I'm more comfortable with the current code than this one.

Can we trim the output then?

Currently we have

-  outs() << Argv0 << ": supported targets: "
-         << "elf32-i386 elf32-iamcu elf32-littlearm elf32-ntradbigmips "
-         << "elf32-ntradlittlemips elf32-powerpc elf32-tradbigmips "
-         << "elf32-tradlittlemips elf32-x86-64 "
-         << "elf64-amdgpu elf64-littleaarch64 elf64-powerpc elf64-tradbigmips "
-         << "elf64-tradlittlemips elf64-x86-64\n";

Could we print something like "elf32-* elf64-*"?

Cheers,
Rafael


More information about the llvm-commits mailing list