[PATCH] D42707: [DWARFv5] Emit .debug_line_str (in a non-DWO file)

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:245-246
+  // In a v5 non-split line table, put the strings in a separate section.
+  bool UseLineStr = context.getDwarfVersion() >= 5;
+  MCDwarfLineStr LineStr(context);
+
----------------
Maybe using an Optional<MCDwarfLineStr> (you've got the bool and the MCDwarfLineStr there already, this would just wrap it up together & avoid the construction of an MCDwarfLineStr when it's not used)


https://reviews.llvm.org/D42707