[PATCH] D42707: [DWARFv5] Emit .debug_line_str (in a non-DWO file)

[Paul Robinson via Phabricator via llvm-commits]

probinson updated this revision to Diff 132930.
probinson added a comment.

Address review comments:  
Pass the MCDwarfLineStr around by pointer, eliminating the operator-bool; 
use new dwarfdump feature in the test to show the section for the string references; 
put more responsibility on the (only) user of the class.

That last bit is not really my preference, but as this new class is basically an implementation detail within MCDwarf.cpp I think it should be okay.


https://reviews.llvm.org/D42707

Files:
  llvm/include/llvm/MC/MCDwarf.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/MC/StringTableBuilder.h
  llvm/lib/MC/MCDwarf.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/StringTableBuilder.cpp
  llvm/test/MC/ELF/debug-md5.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42707.132930.patch
Type: text/x-patch
Size: 16972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180206/0a4a4f82/attachment.bin>