[PATCH] D42592: [COFF] Add minimal support for /guard:cf

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Thanks!



================
Comment at: lld/COFF/Writer.cpp:949
+    ArrayRef<Symbol *> ObjSymbols = File->getSymbols();
+    for (const ulittle32_t &SymIndex : SymIndices) {
+      if (SymIndex >= ObjSymbols.size()) {
----------------
ruiu wrote:
> ruiu wrote:
> > ulittle32_t is a small object so I wouldn't use it through a reference. I'd just use `uint32_t` here.
> Is this done?
Yes, I think I forgot to quit the editor prompt when I uploaded the next patch.


https://reviews.llvm.org/D42592