[PATCH] D42592: [COFF] Add minimal support for /guard:cf

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: lld/COFF/Writer.cpp:949
+    ArrayRef<Symbol *> ObjSymbols = File->getSymbols();
+    for (const ulittle32_t &SymIndex : SymIndices) {
+      if (SymIndex >= ObjSymbols.size()) {
----------------
ruiu wrote:
> ulittle32_t is a small object so I wouldn't use it through a reference. I'd just use `uint32_t` here.
Is this done?


https://reviews.llvm.org/D42592