[PATCH] D35267: Pass Divergence Analysis data to selection DAG to drive divergence dependent instruction selection
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 5 11:47:29 PST 2018
efriedma added a comment.
I'd like to see a verifier somewhere that the divergence bit is still correct after DAGCombine (it could be different from what SelectionDAG::createOperands would compute given how ReplaceAllUsesWith works).
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:8258
+ if (!TLI->isSDNodeAlwaysUniform(Node))
+ Node->SDNodeBits.IsDivergent = IsDivergent;
+ checkForCycles(Node);
----------------
This is good; I'm happy we're cleanly computing divergence for a DAG node.
https://reviews.llvm.org/D35267
More information about the llvm-commits
mailing list