[PATCH] D42835: [SCEV] Make isLoopEntryGuardedByCond a bit smarter

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:9107
+  // dominating predicates.
+  auto LoosePredicate = [](ICmpInst::Predicate Pred) {
+    switch (Pred) {
----------------
Move this to `CmpInst`, it already has stuff like `CmpInst::getInversePredicate`.

I'd also s/Loose/NonStrict/ since folks are more likely to be familiar with "strict" than with "loose".


================
Comment at: test/Transforms/IRCE/conjunctive-checks.ll:1
 ; RUN: opt -S -verify-loop-info -irce < %s | FileCheck %s
 
----------------
Can you please also add a direct SCEV or IndVars test?


https://reviews.llvm.org/D42835