[PATCH] D42802: [DWARF] Regularize dumping strings from line tables.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 09:14:29 PST 2018


JDevlieghere added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:443
+  if (OS) {
+    DIDumpOptions DumpOptions;
+    DumpOptions.Verbose = true;
----------------
Maybe add a comment here that says that if we execute this path we know we're in verbose mode. Alternatively we could add the `DumpOptions` as an additional default argument but I don't think that's worth it here. 


Repository:
  rL LLVM

https://reviews.llvm.org/D42802





More information about the llvm-commits mailing list