[PATCH] D42802: [DWARF] Regularize dumping strings from line tables.

[Paul Robinson via Phabricator via llvm-commits]

probinson created this revision.
probinson added reviewers: dblaikie, aprantl.
probinson added a project: debug-info.
Herald added subscribers: llvm-commits, JDevlieghere, hiraditya, javed.absar, nhaehnle, emaste, mehdi_amini.
Herald added a reviewer: JDevlieghere.

The major visible difference here is that in line-table dumps,
directory and file names are wrapped in double-quotes; previously,
directory names got single quotes and file names were not quoted at
all.
(I know there have been changes lately to make dwarfdump more like Darwin's.  I hope this change isn't an issue.)

The improvement in this patch is that when a DWARF v5 line table
header has indirect strings, in a verbose dump these will all have
their section[offset] printed as well as the name itself.  This
matches the format used for dumping strings in the .debug_info
section.


Repository:
  rL LLVM

https://reviews.llvm.org/D42802

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
  llvm/test/CodeGen/BPF/dwarfdump.ll
  llvm/test/CodeGen/Generic/dwarf-md5.ll
  llvm/test/CodeGen/X86/dwarf-comp-dir.ll
  llvm/test/DebugInfo/AMDGPU/dwarfdump-relocs.ll
  llvm/test/DebugInfo/Generic/lto-comp-dir.ll
  llvm/test/DebugInfo/X86/dwarfdump-header-64.s
  llvm/test/DebugInfo/X86/dwarfdump-header.s
  llvm/test/DebugInfo/X86/dwarfdump-line-dwo.s
  llvm/test/DebugInfo/X86/dwarfdump-line-only.s
  llvm/test/DebugInfo/X86/generate-odr-hash.ll
  llvm/test/DebugInfo/X86/stmt-list-multiple-compile-units.ll
  llvm/test/DebugInfo/debugmacinfo.test
  llvm/test/Linker/subprogram-linkonce-weak.ll
  llvm/test/MC/ARM/dwarf-asm-multiple-sections.s
  llvm/test/MC/ELF/debug-md5.s
  llvm/test/MC/MachO/gen-dwarf-cpp.s
  llvm/test/MC/MachO/gen-dwarf-macro-cpp.s
  llvm/test/MC/MachO/gen-dwarf.s
  llvm/test/tools/dsymutil/X86/basic-linking-x86.test
  llvm/test/tools/dsymutil/X86/basic-lto-dw4-linking-x86.test
  llvm/test/tools/dsymutil/X86/basic-lto-linking-x86.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42802.132407.patch
Type: text/x-patch
Size: 32963 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180201/9972e0ef/attachment-0001.bin>