[PATCH] D42747: [WebAssembly] Write minimal types section

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 15:06:18 PST 2018


ruiu added inline comments.


================
Comment at: wasm/InputFiles.h:104
   std::vector<uint32_t> TypeMap;
+  std::vector<bool> TypeIsUsed;
   std::vector<InputSegment *> Segments;
----------------
ncw wrote:
> There is a class llvm::BitVector, but I don't know whether it's preferred over std::vector<bool> (presumably, or it wouldn't have been written?)
I'm fine with this code. I prefer std containers over llvm's in this case because I don't think there's a large difference.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42747





More information about the llvm-commits mailing list