[PATCH] D42747: [WebAssembly] Write minimal types section

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 10:43:12 PST 2018


ncw accepted this revision.
ncw added a comment.
This revision is now accepted and ready to land.

LGTM, can't see any potential problems (just endless merge conflicts coming up - I've just finished rebasing onto the GC changes...)



================
Comment at: wasm/InputFiles.h:104
   std::vector<uint32_t> TypeMap;
+  std::vector<bool> TypeIsUsed;
   std::vector<InputSegment *> Segments;
----------------
There is a class llvm::BitVector, but I don't know whether it's preferred over std::vector<bool> (presumably, or it wouldn't have been written?)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42747





More information about the llvm-commits mailing list