[PATCH] D42539: [WebAssembly] Handle relocations where provisional value != index

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Yes, you're right - we could write a check that would verify the correct provisional value is being written out. But that would mean building effectively a symbol table for each input file, and we currently don't have a structure that models the WasmObjectWriter symbol table - since things like aliases and weak symbols etc are globally resolved as soon as we put them in LLD's symbol table. So the symbol lookup table we'd need would have to be per-file, and it just doesn't seem worth it at the moment.

We could do it though - I'd be up for it, if it needs doing. But there's lots of missing input validation in WasmObjectFile, I'm not sure the provisional values are the top priority.

I agree it's good to be careful when removing checks.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42539