[PATCH] D42539: [WebAssembly] Handle relocations where provisional value != index

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Oh I see.  I thought we already had such cases, but its only after https://reviews.llvm.org/D42095 that this would actually start breaking.

With respect the provisional value, isn't it the case the every function symbol must point to a valid function index (either an imported or defined function)?  So can't we continue to write a reasonable provisional value, and then verify that here?

I know there can be 1 to many relationship between symbols and functions, but that doesn't stop us from writing the provisional index and then also checking it here does it?  I guess the check is not a big deal, but it certainly helped during development to spot when my offsets were wrong.   I guess  I don't mind dropping it now.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42539