[PATCH] D42707: [DWARFv5] Emit .debug_line_str (in a non-DWO file)

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:321
+  LineStrings.finalizeInOrder();
+  SmallString<0> Data;
+  Data.resize(LineStrings.getSize());
----------------
aprantl wrote:
> Sounds like a std::vector<uint_8t> or something would also be sufficient (but I'm not sure if that's any more efficient).
This sequence is cargo-culting StringTableBuilder::write(raw_ostream&).  I don't think a std::vector would be any more efficient, and EmitBinaryData wants a StringRef anyway which I'd have to construct manually.


Repository:
  rL LLVM

https://reviews.llvm.org/D42707