[PATCH] D42707: [DWARFv5] Emit .debug_line_str (in a non-DWO file)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 13:58:44 PST 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Looks reasonable.



================
Comment at: llvm/lib/MC/MCDwarf.cpp:321
+  LineStrings.finalizeInOrder();
+  SmallString<0> Data;
+  Data.resize(LineStrings.getSize());
----------------
Sounds like a std::vector<uint_8t> or something would also be sufficient (but I'm not sure if that's any more efficient).


Repository:
  rL LLVM

https://reviews.llvm.org/D42707





More information about the llvm-commits mailing list